Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: counterfactual safe tracking #3783

Merged
merged 1 commit into from
May 31, 2024
Merged

fix: counterfactual safe tracking #3783

merged 1 commit into from
May 31, 2024

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented May 30, 2024

What it solves

Resolves https://www.notion.so/safe-global/1f1df3f06ead4378ab1c9c3de24951b1?v=6ad2667b868d4c0f8cf18e129f762583&p=cf2a606d10e94de49050d87973a54621&pm=s

How this PR fixes it

  • Does not track owned Safes if no wallet is connected

How to test it

  • Add a counterfactual Safe
  • observe that nothing is logged without owner connected
  • Observe that with owner connected the counts are correct

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@schmanu schmanu requested a review from usame-algan May 30, 2024 15:36
@github-actions GitHub Actions
Copy link

github-actions bot commented May 30, 2024 •
edited
Loading

Branch preview

✅ Deploy successful!

Website:
https://fix_safe_tracking_counterfactual--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook:
https://fix_safe_tracking_counterfactual--walletweb.review.5afe.dev/storybook/

@github-actions GitHub Actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@github-actions GitHub Actions
Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 950.03 KB (🟡 +5 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@github-actions GitHub Actions
Copy link

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements
79.47% (-0.02% 🔻)
 11295/14213
🔴 Branches
58.46% (-0.02% 🔻)
 2699/4617
🟡 Functions
66.67% (-0.04% 🔻)
 1822/2733
🟢 Lines
80.85% (-0.02% 🔻)
 10185/12597
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟢
... / index.tsx
82.35% (-8.82% 🔻)
66.67% (-16.67% 🔻)
50% (-12.5% 🔻)
83.87% (-9.68% 🔻)

Test suite run success

1436 tests passing in 197 suites.

Report generated by 🧪jest coverage report action from 5362ee8

@schmanu schmanu merged commit 7537a62 into dev May 31, 2024
14 checks passed
@schmanu schmanu deleted the fix/safe-tracking-counterfactual branch May 31, 2024 08:02
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@usame-algan usame-algan usame-algan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schmanu @usame-algan